Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CPU% #3262

Open
wants to merge 3 commits into
base: development
Choose a base branch
from
Open

Fix CPU% #3262

wants to merge 3 commits into from

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Feb 27, 2025

What does this implement/fix?

Two changes:

  • Show load instead of CPU % in info box as this (a) is more meaningful (naturally includes IOWait, etc.) and (b) is what we have shown in v5 as well so users are used to seeing these values even if they are less intuitive than CPU % at first
  • Still show total CPU % on settings / system info tab for easy contrasting to the CPU % used by FTL

grafik

Needs FTL branch new/total_cpu to work pi-hole/FTL#2297


Related issue or feature (if applicable): Fixes #3261

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

@DL6ER DL6ER requested a review from a team February 27, 2025 05:08
Co-authored-by: RD WebDesign <[email protected]>
Signed-off-by: Dominik <[email protected]>
@DL6ER DL6ER requested a review from rdwebdesign February 27, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants